stabilize (const_)ptr_sub_ptr
#137121
Merged
stabilize (const_)ptr_sub_ptr
#137121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
The Miri subtree was changed cc @rust-lang/miri |
rustbot
added
the
T-libs
|
@rust-lang/wg-const-eval is this OK to make const stable? |
|
This has no new const eval interactions over |
RalfJung
reviewed
Feb 16, 2025
|
Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @rust-lang/wg-const-eval |
bend-n
force-pushed
the
master
branch
2 times, most recently
from
28a27e4 to
9300294
Compare
|
☔ The latest upstream changes (presumably #137143) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 22, 2025
stabilize `(const_)ptr_sub_ptr` Tracking issue: rust-lang#95892 Closes rust-lang#95892 FCP Completed: rust-lang#95892 (comment) r? `@Noratrieb`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 22, 2025
stabilize `(const_)ptr_sub_ptr` Tracking issue: rust-lang#95892 Closes rust-lang#95892 FCP Completed: rust-lang#95892 (comment) r? ``@Noratrieb``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#135501 (Inject `compiler_builtins` during postprocessing and ensure it is made private) - rust-lang#136543 (intrinsics: unify rint, roundeven, nearbyint in a single round_ties_even intrinsic) - rust-lang#137121 (stabilize `(const_)ptr_sub_ptr`) - rust-lang#137180 (Give `global_asm` a fake body to store typeck results, represent `sym fn` as a hir expr to fix `sym fn` operands with lifetimes) - rust-lang#137256 (compiler: untangle SIMD alignment assumptions) - rust-lang#137298 (Check signature WF when lowering MIR body) - rust-lang#137415 (Remove invalid suggestion of into_iter for extern macro) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 22, 2025
stabilize `(const_)ptr_sub_ptr` Tracking issue: rust-lang#95892 Closes rust-lang#95892 FCP Completed: rust-lang#95892 (comment) r? ```@Noratrieb```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#135501 (Inject `compiler_builtins` during postprocessing and ensure it is made private) - rust-lang#136543 (intrinsics: unify rint, roundeven, nearbyint in a single round_ties_even intrinsic) - rust-lang#137121 (stabilize `(const_)ptr_sub_ptr`) - rust-lang#137180 (Give `global_asm` a fake body to store typeck results, represent `sym fn` as a hir expr to fix `sym fn` operands with lifetimes) - rust-lang#137256 (compiler: untangle SIMD alignment assumptions) - rust-lang#137383 (stabilize `unsigned_is_multiple_of`) - rust-lang#137415 (Remove invalid suggestion of into_iter for extern macro) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 23, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#135501 (Inject `compiler_builtins` during postprocessing and ensure it is made private) - rust-lang#137121 (stabilize `(const_)ptr_sub_ptr`) - rust-lang#137180 (Give `global_asm` a fake body to store typeck results, represent `sym fn` as a hir expr to fix `sym fn` operands with lifetimes) - rust-lang#137256 (compiler: untangle SIMD alignment assumptions) - rust-lang#137383 (stabilize `unsigned_is_multiple_of`) - rust-lang#137415 (Remove invalid suggestion of into_iter for extern macro) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 23, 2025
Rollup merge of rust-lang#137121 - bend-n:master, r=Noratrieb stabilize `(const_)ptr_sub_ptr` Tracking issue: rust-lang#95892 Closes rust-lang#95892 FCP Completed: rust-lang#95892 (comment) r? ````@Noratrieb````
5 tasks
|
Uh, the name for the function is wrong -- thanks @hanna-kruppe for pointing this out. This needs either a quick revert or a quick rename to |
|
@bend-n can you do the rename within the next ~48h? If not, I'll send a revert for this PR. |
|
wow, that's really unfortunate. @rust-lang/libs-api it would be really nice if the tracking issue description actually reflected what was FCPed^^', I did not think it would be necessary to actually read the entire comment history to figure out if this was correct. |
oh no! my bad. ill update the names immediately |
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Feb 23, 2025
rename sub_ptr to offset_from_unsigned i also made `byte_sub_ptr` `byte_offset_from_unsigned` fixes rust-lang#137121 tracking issue rust-lang#95892
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 24, 2025
Rollup merge of rust-lang#137483 - bend-n:😅, r=Noratrieb rename sub_ptr to offset_from_unsigned i also made `byte_sub_ptr` `byte_offset_from_unsigned` fixes rust-lang#137121 tracking issue rust-lang#95892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #95892
Closes #95892
FCP Completed: #95892 (comment)
r? @Noratrieb